Bump mongodb_backup version after the import fix so the fix can be published to charmcraft #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delgod
approved these changes
Nov 6, 2023
MiaAltieri
approved these changes
Nov 6, 2023
so the fix can be published to charmcraft
dmitry-ratushnyy
force-pushed
the
bump_mongodb_backup_version
branch
from
03e0cca to
7ff884e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The library published to charmcraft contains incorrect import of
from charms.mongodb.v0.helpers import current_pbm_op, process_pbm_status.The correct import statement is
from charms.mongodb.v1.helpers import current_pbm_op, process_pbm_statusand it was fixed in this PR, however the library version was not bumped, so the fix can not be published.Solution
Bump the library version